Question

I’m trying to remove an item from a sorted list. If the item is not in the list, then the list remains unchanged. If the item occurs multiple times, only one occurrence of the item is removed. Again, I’m not allowed to use build-in list functions, but for the time being, I’m just trying to get the code to just work!

class SortedList:
    def __init__(self):
        self.s_list = []
    def insert(self, item):
        self.s_list.append(item)

    def remove(self, item):
        finalSet=[]
        for item in self.s_list:
            if item not in finalSet:
                finalSet.append(item)
                return finalSet
    def __str__(self):
        return str(self.s_list)

Answer 1

Your remove function seems very confused.

def remove(self, item):
    finalSet=[]
    for item in self.s_list:
        if item not in finalSet:
            finalSet.append(item)
            return finalSet

1. Why are you creating a new list, shouldn’t you be modifying the existing list?
2. There are two different item in the function. One is a parameter to the function, the other is in the loop. The one in the loop replaces the parameter. Give them different names
3. You return with the list almost right away, you probably don’t want to return until after the loop is completed. Your return statement is intended too far
4. Since you’ve confused two different variables by giving them the same name, I can’t guess what you were actually trying to do inside the loop.