Question

I’m trying to see if when a user enters some text it searches the array for any matches, and whatever doesn’t match gets removed from the array;

string search = textBox1.Text;
for (int i = 0; i < staffUsers.Count; i++)
{
    if (!(staffUsers[i].staff_name.Contains(search)))
    {
        staffUsers.Remove(staffUsers[i]);
    }
}

I have some rubbish names in my array ‘Rob Dob’,’Joe Bloggs’, ‘h h’, ‘ghg hgh’, and if the search variable ended up being ‘R’, Joe Bloggs would get removed but ‘h h’ and ‘ghg hgh’ stay there, but there is no R involved there at all? any reason why>?!

Answer 1

You have to iterate backwards in order to remove from an array. Every time you remove an item, your array gets smaller. By going backwards, that fact does not matter.

string search = textBox1.Text;

for (int i = staffUsers.Count - 1; i >= 0 ; i--)
{
    if (!(staffUsers[i].staff_name.Contains(search)))
    {
        staffUsers.Remove(staffUsers[i]);
    }
}