Question

I’m trying to sort an array made of random numbers from 1 to 10 in an ascending order. I’ve come up with this function:

void Sort(int a[10], int n)
{
    int j = 0;
    for (int i = 0; i < n-1; i++)
    {
        j = i+1;
        if (a[i] > a[j])
        {
            int aux = a[i];
            a[i] = a[j];
            a[j] = aux;
        }
    }
}

But when I try to output the array, the function doesn’t seem to have worked:

Sort(array, 10);

    cout<<endl;

    for (int i = 0; i < 10; i++)
    {
        cout<<array[i]<<" ";
    }

Answer 1

The algorithm in your Sort function is wrong. It doesn’t sort at all.

Anyway, don’t reinvent the wheel, better use std::sort as:

#include <algorithm>

std::sort(array, array+10);

---

As for your Sort function, which you want to implement using bubble-sort algorithm, possibly for learning purpose. the correct implementation is this:

void Sort(int *a, int n)
{
    for (int i = 0; i < n ; i++)
    {
       for (int j =  i + 1; j < n ; j++)
       {
           if (a[i] > a[j])
           {
              int aux = a[i];
              a[i] = a[j];
              a[j] = aux;
           }
       }
    }
}