Question

I’m trying to sort strings according to their names lexicographically.

so I have an array of structures

typedef struct buff{
    char *name;
} structure;

and I’m copying names of files with their associated extensions. So that the content of that structure looks like s[0].name = "picture1.jpg" s[1].name = "DCP003.JPG" and stuff like that.

and I’m trying to sort that, and I’m unable to achieve that.. what I have so far is this.

void sort(structure *s, int counter){

    for (int i = 0; i < counter - 1; i++){
        for (int j = 0; j < counter - 1 - i; j++){

                if (strcmp(s[j].name, s[j+1].name) > 0){

                    structure tmp;

                    tmp = s[j];
                    s[j] = s[j+1];
                    s[j+1] = tmp;

            }
        }
    }

    for (int i = 0; i < counter; i++){
        printf("%d - %s\n", i+1, s[i].name);
    }
}

and it doesn’t work as I want.. tried several versions still no good .. where am I making mistake? Any advice is greatly appreciated..

Answer 1

Try something like this:

typedef struct buff{
    char *name;
} structure;

structure s[5];

void sort(){
    int sz = sizeof s / sizeof s[0];
    printf("sz=%d\n",sz);
    int done = 0;

    for (int i = 0; i < sz; i++){
          for (int j = i+1; j < sz; j++){

                  if (strcmp(s[i].name, s[j].name) > 0){

                      structure tmp;

                      tmp = s[i];
                      s[i] = s[j];
                      s[j] = tmp;
              }
          }
    }
    for (int i = 0; i < sz; i++){
        printf("%d - %s\n", i+1, s[i].name);
    }
}

int main() {
  s[0].name = "dog";
  s[1].name = "ant";
  s[2].name = "cat";
  s[3].name = "man";
  s[4].name = "bear";
  sort();
  return 0;
}

Output:

---------- Capture Output ----------
> "c:\windows\system32\cmd.exe" /c c:\temp\temp.exe
sz=5
1 - ant
2 - bear
3 - cat
4 - dog
5 - man

> Terminated with exit code 0.