Question

I’m trying to write data to registry, but it always writes foreigner language instead because the setvalue is “MyApp”

CStringA temp(setvalue);//setvalue is CString type
const BYTE* pData = (const BYTE*)(LPCSTR)temp;
lResult = RegSetValueEx(hKey, path, NULL, REG_SZ, (LPBYTE)pData, sizeof(pData));
RegCloseKey(hKey);

if(lResult == ERROR_SUCCESS || lResult == ERROR_MORE_DATA)
    return true;
else
    return false;

thanks.

Answer 1

The way you are converting CString to BYTE* is causing the problem. No need of using CStringA.

Try this conversion of CString to TCHAR. This should work

LPTSTR lpszData = new TCHAR[setvalue.GetLength()+1]; // setvalue is CString type...
_tcscpy(lpszData , csTemp);

lResult = RegSetValueEx(hKey, path, NULL, REG_SZ, (LPBYTE)lpszData, setvalue.GetLength()+1);

delete[] lpszData;// don't forget to do this.