Question

I’m used to seeing old code like

if (true)
{
    ...
}

where it’s intuitively clear that someone was being either lazy or overly cautious when making a change. I ran across this snippet today, and I’m curious whether there’s a functional difference between doing type comparison this way:

private static bool logField(Type t, string fieldname)
{
    if (t.ToString() == typeof (Property).ToString())
    {
        ...
    }
    return true;
}

and doing it this way:

private static bool logField(Type t, string fieldname)
{
    if (t == typeof (Property))
    {
        ...
    }
    return true;
}

Answer 1

No, getting the type object of 2 instances of the same type will always return a reference to the same type object in memory. This means that performing a reference equality check (==) is sufficient.

Essentially, calling:
if (t.ToString() == typeof (Property).ToString())

will call ToString() twice on the same object, where t is the ‘Property’ type.