Question

I’m using C++ Visual Studio .Net 4.0 on Windows 7.0 x64. This happens just on the first loop of the while statement.

int main()
{
  char *string = new char[11];

  string = "characters\0";

  toUppercase(string);

  return 0;
}



void toUppercase(char *stringPtr)
{
 while(*stringPtr != '\0')
 {
    if(*stringPtr >= 'a' && *stringPtr <= 'z')
    {
        *stringPtr = *stringPtr - 32; // this is the culprit
    }

    ++stringPtr;    
 }
}

Answer 1

I suspect you’re doing something like this:

toUppercase("test");

The problem is "test" is an array of const char, not char, so cannot be modified. However, due to a terribly stupid deprecated special conversion, a string literal can be treated as char* anyway.

(Your function also fails to test for toUppercase(0).)