Question

I’m using the code below to make sure only confirmed users (confirmed is 1, else 0) can login, but this code displays the apologize message no matter what. How can I fix this? Thanks!

// make sure the user is confirmed
    $confirmstatus = query("SELECT * FROM users WHERE username = ?", $_POST["username"]);
    if ($confirmstatus["confirmed"] == 0)
    {
        apologize("Please first confirm your account.");
    }

This is the query function

    /**
 * Executes SQL statement, possibly with parameters, returning
 * an array of all rows in result set or false on (non-fatal) error.
 */
function query(/* $sql [, ... ] */)
{
    // SQL statement
    $sql = func_get_arg(0);

    // parameters, if any
    $parameters = array_slice(func_get_args(), 1);

    // try to connect to database
    static $handle;
    if (!isset($handle))
    {
        try
        {
            // connect to database
            $handle = new PDO("mysql:dbname=" . DATABASE . ";host=" . SERVER, USERNAME, PASSWORD);

            // ensure that PDO::prepare returns false when passed invalid SQL
            $handle->setAttribute(PDO::ATTR_EMULATE_PREPARES, false); 
        }
        catch (Exception $e)
        {
            // trigger (big, orange) error
            trigger_error($e->getMessage(), E_USER_ERROR);
            exit;
        }
    }

    // prepare SQL statement
    $statement = $handle->prepare($sql);
    if ($statement === false)
    {
        // trigger (big, orange) error
        trigger_error($handle->errorInfo()[2], E_USER_ERROR);
        exit;
    }

    // execute SQL statement
    $results = $statement->execute($parameters);

    // return result set's rows, if any
    if ($results !== false)
    {
        return $statement->fetchAll(PDO::FETCH_ASSOC);
    }
    else
    {
        return false;
    }
}

And this is the apologize function

   /**
 * Apologizes to user with message.
 */
function apologize($message)
{
    render("apology.php", ["message" => $message]);
    exit;
}

And the render function.

    /**
 * Renders template, passing in values.
 */
function render($template, $values = [])
{
    // if template exists, render it
    if (file_exists("../templates/$template"))
    {
        // extract variables into local scope
        extract($values);

        // render header
        require("../templates/header.php");

        // render template
        require("../templates/$template");

        // render footer
        require("../templates/footer.php");
    }

    // else err
    else
    {
        trigger_error("Invalid template: $template", E_USER_ERROR);
    }
}

Answer 1

Try Running:

$confirmstatus = query("SELECT * FROM users WHERE username = ?", $_POST["username"]);
print_r($confirmstatus);

Double check that your function is infact returning an array.

Also try this as your query:

    $Checkusername = $_POST['username'];
   $confirmstatus = query("SELECT * FROM users WHERE username = '$Checkusername'");

Also. Your

function query(/* $sql [, ... ] */)
{ }

The Variables which are being passed through to the function have been commented out. If this is exactly like your code.. then I would recommend a revision to:

function query ($sql)
{ .... }

EDIT

 if ($confirmstatus["0"]['confirmed'] == 0)
    {
        apologize("Please first confirm your account.");
    }

I overlooked something. It seems you are being returned a multidimensional array
You need to look into the first array (in this case 0) and then look for your required field.