Question

Im wondering if anyone could help me please, im new to android and am trying to write a small app which shows a camera preview from the front camera, all works good BUT when i close the app the phone freezes then crashes, ive been looking for an answer to this but cant seem to find one anywhere, code follows

import android.app.Activity;
import android.hardware.Camera;
import android.media.MediaPlayer;
import android.os.Bundle;
import android.os.CountDownTimer;
import android.util.Log;
import android.view.SurfaceHolder;
import android.view.SurfaceView;
import android.view.View;
import android.widget.ImageView;
import android.widget.Toast;

public class PreviewDemo extends Activity {

  private SurfaceView preview=null;
  private SurfaceHolder previewHolder=null;
  private Camera camera=null;
  private boolean inPreview=false;
  private boolean cameraConfigured=false;   
  public ImageView imageview1;
  public MediaPlayer mp;
  public MediaPlayer mp2;
  public MyCountDownTimer counter = new MyCountDownTimer(6000,1000);
  public MyCountDownTimer2 counter2 = new MyCountDownTimer2(2000,1000);


  @Override
  public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main);
    mp = MediaPlayer.create(PreviewDemo.this, R.raw.shatter);
    mp2 = MediaPlayer.create(PreviewDemo.this, R.raw.beep);
    preview=(SurfaceView)findViewById(R.id.preview);
    previewHolder=preview.getHolder();
    previewHolder.addCallback(surfaceCallback);
    previewHolder.setType(SurfaceHolder.SURFACE_TYPE_PUSH_BUFFERS);
    imageview1 = (ImageView) this.findViewById(R.id.imageView1);
    counter2.start();

  }

  @Override
  public void onResume() {
    super.onResume();
    int cameraCount = 0;
    Camera.CameraInfo cameraInfo = new Camera.CameraInfo();
    cameraCount = Camera.getNumberOfCameras();
            for ( int camIdx = 0; camIdx < cameraCount; camIdx++ ) {
        Camera.getCameraInfo( camIdx, cameraInfo );
        if ( cameraInfo.facing == Camera.CameraInfo.CAMERA_FACING_FRONT  ) {
            try {
                camera = Camera.open( camIdx );
                camera.setDisplayOrientation(90);
            } catch (RuntimeException e) {
                ;
            }
        }
    startPreview();
  }
  }
  @Override
  public void onPause() {
    if (inPreview) {
      camera.stopPreview();
    }

    camera.release();
    camera=null;
    inPreview=false;

    super.onPause();
  }
  public void onFinish(){
  }

  private Camera.Size getBestPreviewSize(int width, int height,
                                         Camera.Parameters parameters) {
    Camera.Size result=null;

    for (Camera.Size size : parameters.getSupportedPreviewSizes()) {
      if (size.width<=width && size.height<=height) {
        if (result==null) {
          result=size;
        }
        else {
          int resultArea=result.width*result.height;
          int newArea=size.width*size.height;

          if (newArea>resultArea) {
            result=size;
          }
        }
      }
    }

    return(result);
  }

  private void initPreview(int width, int height) {
    if (camera!=null && previewHolder.getSurface()!=null) {
      try {
        camera.setPreviewDisplay(previewHolder);
      }
      catch (Throwable t) {
        Log.e("PreviewDemo-surfaceCallback",
              "Exception in setPreviewDisplay()", t);
        Toast
          .makeText(PreviewDemo.this, t.getMessage(), Toast.LENGTH_LONG)
          .show();
      }

      if (!cameraConfigured) {
        Camera.Parameters parameters=camera.getParameters();
        Camera.Size size=getBestPreviewSize(width, height,
                                            parameters);

        if (size!=null) {
          parameters.setPreviewSize(size.width, size.height);
          camera.setParameters(parameters);
          cameraConfigured=true;
        }
      }
    }
  }

  private void startPreview() {
    if (cameraConfigured && camera!=null) {
      camera.startPreview();
      inPreview=true;
    }
  }

  SurfaceHolder.Callback surfaceCallback=new SurfaceHolder.Callback() {
    public void surfaceCreated(SurfaceHolder holder) {
      // no-op -- wait until surfaceChanged()
    }

    public void surfaceChanged(SurfaceHolder holder,
                               int format, int width,
                               int height) {
      initPreview(width, height);
      startPreview();
    }

    public void surfaceDestroyed(SurfaceHolder holder) {
        camera.stopPreview();
        camera.setPreviewCallback(null); 
        camera.release();
        camera = null;

    }
  };
  public class MyCountDownTimer extends CountDownTimer{


      public MyCountDownTimer(long millisInFuture, long countDownInterval) {
      super(6000, 1000);
      }

      @Override
      public void onFinish() {
          imageview1.setVisibility(View.VISIBLE); 
          mp.start();
      }

      public void onTick(long millisUntilFinished) {
          mp2.start();
        }

      }

  public class MyCountDownTimer2 extends CountDownTimer{


      public MyCountDownTimer2(long millisInFuture, long countDownInterval) {
      super(2000, 1000);
      }

      @Override
      public void onFinish() {
          counter.start();
      }

      public void onTick(long millisUntilFinished) {

        }

      }
}

Cheers in advance
Mark

Answer 1

You need to check if camera is valid, since you set camera = null in multiple places like onPause() and your SurfaceView onSurfaceDestroyed() callback. Your onPause() method should look like this:

@Override
public void onPause() {
    if(camera != null) {
        if (inPreview) {
          camera.stopPreview();
        }

        camera.release();
        camera=null;
    }
    inPreview=false;

    super.onPause();
}

This same logic is true for onSurfaceDestroyed(). Also your code might be easier to maintain if you move this logic into a closeCamera() method and call this method from valid locations.