Question

I’m working an a script with product filters. Everything works fine but it’s too slow. The reason is too much query’s. Query5 selects about 200 entrys. Query12 “search” in 130.000 entry’s.

Is it possible to make a mysql join or something faster of this with less query’s?

    <?php
                $query5 = mysql_query("SELECT id,fabrikant,naam FROM producten_new WHERE icecat_cat='".secure_in($obj->icecat)."'".$selecteren.""); 
                while($row5 = mysql_fetch_assoc($query5)){ 

                    foreach($_GET as $key=>$value){ 
                            if($key != "p" AND $key != "id" AND $key != "merk" AND $key != "submit" AND $value != "0"){ 

                                $query12 = mysql_query("SELECT COUNT(id) as aantal FROM producten_specs WHERE name='".secure_in(str_replace("_", " ", $key))."' AND value='".secure_in($value)."' AND product_id='".secure_in($row5['id'])."'"); 
                                $data12 = mysql_fetch_assoc($query12); 

                                if($data12['aantal']){ 
                                    $product_present = TRUE; 
                                } else { 
                                    $product_present = FALSE; 
                                    break;
                                } 

                            } 
                    }
                    if($product_present){
                        echo $row5['id']."<br />";
                        $product_present = FALSE;
                    }
               }
    ?>

Thanks.

EDIT:
Ok, fresh start. I hope its better (faster) this way:

        //Select products from category and brand
        $query5 = mysql_query("SELECT id FROM producten_new WHERE icecat_cat='".secure_in($obj->icecat)."'".$selecteren."");
        while($row5 = mysql_fetch_assoc($query5)){
            $query5_ids .= $row5['id'].", ";
        }
        //Remove last ','
        $query5_ids = substr($query5_ids, 0, -2);

        //Get all $_GET's
        foreach($_GET as $key=>$value){
            if($key != "p" AND $key != "id" AND $key != "merk" AND $key != "submit" AND $value != "0"){
                $specs_gets .= $key.",".$value.";";
                $count_gets++;
                $selection .= "name='".secure_in(str_replace("_", " ", $key))."' AND value='".secure_in($value)."' OR ";
            }
        }
        //Remove last ';'
        $specs_gets = substr($specs_gets, 0, -1);


        //$selection = " AND ".substr($selection, 0, -4);
        $selection = substr($selection, 0, -4);


        //THE query..
        //$query12 = mysql_query("SELECT product_id FROM producten_specs WHERE product_id IN ('".secure_in($query5_ids)."') ".$selection." ORDER BY product_id ASC");
        $query12 = mysql_query("SELECT product_id FROM producten_specs WHERE ".$selection." ORDER BY product_id ASC");
        while($row12 = mysql_fetch_assoc($query12)){

            if($product_hold == $row12['product_id']){
                $product_hold_count++;
            } else {
                $product_hold_count = FALSE;
                $product_hold = $row12['product_id'];
                $product_hold_count = 1;
            }

            if($product_hold_count == $count_gets){

                $query12_ids_ok .= $row12['product_id'].", ";
                $count_products++;
            }

        }
        //Remove last ','
        $query12_ids_ok = substr($query12_ids_ok, 0, -2);

EDIT2
Link to the website: snip

EDIT3
Some more information:

Example of the URL:

index.php
?p=categorie
&id=5
&brand=Asus
&Display_inch=0
&Resolution=0
&Buldin_camera=0
&Chipset=0
&Processor-speed=2400+MHz
&Processorfamilie=0
&Hard+disk-interface=0
&Total+capacitie=500+GB
*snip (because its very long)*
&submit=Submit+Filter

The database:

product_new (contains 3500 entrys) – Contains general product information

id, supplier, price, icecat_cat, name, etc.

1, Asus, 500, Notebook, K72F

product_specs (contains 130.000 entrys) – Contians product specifications

id, product_id, cat, name, value

1, 1, Processor, Processor-speed, 2400 Mhz

2, 1, Harddisk, Total-capacitie, 500 GB

EDIT4
I’m getting closer, see the code in my first edit, only product_id IN (‘”.secure_in($query5_ids).”‘) must be added into query12. Then I get the results I want and a lot faster! Anyone?

Answer 1

Got it!! Thanks for cooperate!

    //Producten selecteren uit categorie en merk 
    $query5 = mysql_query("SELECT id FROM producten_new WHERE icecat_cat='".secure_in($obj->icecat)."'".$selecteren.""); 
    while($row5 = mysql_fetch_assoc($query5)){ 
        $query5_ids .= $row5['id'].", "; 
    } 
    //Laatste , weg halen 
    $query5_ids = substr($query5_ids, 0, -2); 

    //Gets op een rijte zetten 
    foreach($_GET as $key=>$value){ 
        if($key != "p" AND $key != "id" AND $key != "merk" AND $key != "submit" AND $value != "0"){ 
            $specs_gets .= $key.",".$value.";"; 
            $aantal_gets++; 
            $uiteindelijk_selecteren .= "name='".secure_in(str_replace("_", " ", $key))."' AND value='".secure_in($value)."' OR "; 
        } 
    } 
    //Laatste ; weg halen 
    $specs_gets = substr($specs_gets, 0, -1); 


    //$uiteindelijk_selecteren = " AND ".substr($uiteindelijk_selecteren, 0, -4); 
    $uiteindelijk_selecteren = substr($uiteindelijk_selecteren, 0, -4); 


    //Overeenkomend met de get's selecteren 
    $query12 = mysql_query("SELECT product_id FROM producten_specs WHERE product_id IN (".secure_in($query5_ids).") AND ".$uiteindelijk_selecteren." ORDER BY product_id ASC");
    while($row12 = mysql_fetch_assoc($query12)){ 

        if($product_onthouden == $row12['product_id']){ 
            $product_onthouden_aantal++; 
        } else { 
            $product_onthouden_aantal = FALSE; 
            $product_onthouden = $row12['product_id']; 
            $product_onthouden_aantal = 1; 
        } 

        if($product_onthouden_aantal == $aantal_gets){ 

            $query12_ids_ok .= $row12['product_id'].", "; 
            $aantal_producten++; 
        } 

    } 
    //Laatste , weg halen 
    $query12_ids_ok = substr($query12_ids_ok, 0, -2);