Question

I’m working in Android application where I have to fetch last 20 dialled calls.

Here’s is my activity:

public class Calls extends Activity {
    public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.calls);
    TextView dialledCall = (TextView)findViewById(R.id.dialledCall);
        Cursor managedCursor;
    try {

StringBuffer sb = new StringBuffer();
            String strOrder = CallLog.Calls.DATE + " DESC";
            managedCursor = managedQuery( CallLog.Calls.CONTENT_URI,null, CallLog.Calls.TYPE + " = " + CallLog.Calls.OUTGOING_TYPE,null, strOrder + " LIMIT 0, 6");
            managedCursor.moveToFirst();
            int number = managedCursor.getColumnIndex( CallLog.Calls.NUMBER );
            int type = managedCursor.getColumnIndex( CallLog.Calls.TYPE );
            int date = managedCursor.getColumnIndex( CallLog.Calls.DATE);
            int duration = managedCursor.getColumnIndex( CallLog.Calls.DURATION);
            sb.append( "Dialled Calls :");

            while ( managedCursor.moveToNext() ) {
            String phNumber = managedCursor.getString( number );
            String callType = managedCursor.getString( type );
            String callDate = managedCursor.getString( date );
            Date callDayTime = new Date(Long.valueOf(callDate));
            String callDuration = managedCursor.getString( duration );
            String dir = null;
            int dircode = Integer.parseInt( callType );

            switch( dircode ) {
            case CallLog.Calls.OUTGOING_TYPE:
            dir = "Dialled";
            break;
            }

            sb.append( "\nPhone Number : "+phNumber +" \nCall Type : "+dir+" \nCall Date : "+callDayTime+" \nCall duration in sec : "+callDuration );
            sb.append("\n----------------------------------");          
            }
            sb.append("\n==================================");
            sb.append("\n\n");
            managedCursor.close();
            Toast.makeText(this, "Eureka :)", Toast.LENGTH_SHORT).show();

            managedCursor = managedQuery( CallLog.Calls.CONTENT_URI,null, CallLog.Calls.TYPE + " = " + CallLog.Calls.INCOMING_TYPE,null, strOrder + " LIMIT 0, 6");
            managedCursor.moveToFirst();
            int number1 = managedCursor.getColumnIndex( CallLog.Calls.NUMBER );
            int type1 = managedCursor.getColumnIndex( CallLog.Calls.TYPE );
            int date1 = managedCursor.getColumnIndex( CallLog.Calls.DATE);
            int duration1 = managedCursor.getColumnIndex( CallLog.Calls.DURATION);
            sb.append( "Received Calls :");
            while ( managedCursor.moveToNext() ) {

            String phNumber1 = managedCursor.getString( number1 );
            String callType1 = managedCursor.getString( type1 );
            String callDate1 = managedCursor.getString( date1 );
            Date callDayTime1 = new Date(Long.valueOf(callDate1));
            String callDuration1 = managedCursor.getString( duration1 );
            String dir1 = null;
            int dircode = Integer.parseInt( callType1 );

            switch( dircode ) {
            case CallLog.Calls.INCOMING_TYPE:
            dir1 = "Received";
            break;
            }
            sb.append( "\nPhone Number : "+phNumber1 +" \nCall Type : "+dir1+" \nCall Date : "+callDayTime1+" \nCall duration in sec : "+callDuration1 );
            sb.append("\n----------------------------------");          
            }
            sb.append("\n==================================");
            sb.append("\n\n");
            managedCursor.close();
            Toast.makeText(this, "Eureka :) 1", Toast.LENGTH_SHORT).show();
        managedCursor.close();
}


 catch (NullPointerException e) {
                // TODO: handle exception
                Toast.makeText(this, "Sorry Man :(", Toast.LENGTH_SHORT).show();
                e.printStackTrace();
            }
        }
        }

And here is the corresponding XML file:

<?xml version="1.0" encoding="utf-8"?>
<ScrollView
  xmlns:android="http://schemas.android.com/apk/res/android"
  android:layout_width="fill_parent"
  android:layout_height="fill_parent"
  android:fillViewport="true" >

<Linearlayout android:layout_height="wrap_content"
 android:layout_width="fill_parent"
android:orientation="vertical">

        <TextView
            android:id="@+id/dialledCall"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_marginLeft="10dp"
            android:textSize="13dp" />

</Linearlayout>
</ScrollView>

Output: I am able to get first 5 dialled numbers, but in the received calls I’m getting even messages.

What am I doing wrong?

Answer 1

Most probably you are missing a permission:

<uses-permission android:name="android.permission.READ_CONTACTS" />

Or your loop is not correct, try this kind of loop instead:

int count = 0;
if (cursor.moveToFirst()) {
  do {
    // Read your row here

    ++count;
  } while (cursor.moveToNext() && count<20);
}
cursor.close();

It would be more efficient also to limit the number of rows directly in the query rather than in the loop itself:

managedQuery( CallLog.Calls.CONTENT_URI, null, 
        CallLog.Calls.TYPE + " = " + CallLog.Calls.OUTGOING_TYPE, 
        null, strOrder + " LIMIT 0, 20");