Question

I’m working on a ListView based app and I have a very weird problem, my ListItems are reappering and the correct item is not shown in the correct spot. For the sake of making this easy to understand I’ve set the text on each ListItem to be the same as it’s position. I’m doing this in my adapters getView() call. If I have my Nexus 7 4 ListItems are visible. If I have a total of 10 ListItems then it will go like 0, 1, 3, 4, 0, 1, 2, 3, 4. This goes for all devices meaining that the number of items initially on screen + 1 will be correct while all other ListItems are rearrenged.

In which part of my code do you guys think my problem lies because right now I’ve been trying to fix this for hours and I’m clueless. All help is very much appreciated.

EDIT:

Here’s my getView():

@Override
public View getView(int position, View convertView, ViewGroup parent) {
    CountdownItem ci = mTitle.get(position);

    if (convertView == null) {
        convertView = mInflater.inflate(R.layout.list_item, parent, false);

        holder = new CountdownViewHolder();
        holder.mTitle = (TextView) convertView.findViewById(R.id.textPrim);
        holder.mSubtitle = (TextView) convertView
                .findViewById(R.id.textSec);
        holder.mDayProgress = (ProgressBar) convertView
                .findViewById(R.id.day_progress);
        holder.mMonthProgress = (ProgressBar) convertView
                .findViewById(R.id.month_progress);
        holder.mYearText = (TextView) convertView
                .findViewById(R.id.year_text);
        holder.day_help = (TextView) convertView
                .findViewById(R.id.day_help);
        holder.month_help = (TextView) convertView
                .findViewById(R.id.month_help);

        holder.setTitle(Integer.toString(position) + " Title");
        holder.setSubtitle(ci.getSubtitle());
        holder.fixImageAndText(position);

        convertView.setTag(holder);
    } else {
        holder = (CountdownViewHolder) convertView.getTag();
    }

    return convertView;
}

Answer 1

You aren’t using the ViewHolder pattern correctly. The following code needs to be moved outside the if/else clause and before return convertView:

   holder.setTitle(Integer.toString(position) + " Title");
   holder.setSubtitle(ci.getSubtitle());
   holder.fixImageAndText(position);