I’m working on a project in C#. The previous programmer didn’t know object oriented programming, so most of the code is in huge files (we’re talking around 4-5000 lines) spread over tens and sometimes hundreds of methods, but only one class. Refactoring such a project is a huge undertaking, and so I’ve semi-learned to live with it for now.
Whenever a method is used in one of the code files, the class is instantiated and then the method is called on the object instance.
I’m wondering whether there are any noticeable performance penalties in doing it this way? Should I make all the methods static ‘for now’ and, most importantly, will the application benefit from it in any way?
From here, a static call is 4 to 5 times faster than constructing an instance every time you call an instance method. However, we’re still only talking about tens of nanoseconds per call, so you’re unlikely to notice any benefit unless you have really tight loops calling a method millions of times, and you could get the same benefit by constructing a single instance outside that loop and reusing it.
Since you’d have to change every call site to use the newly static method, you’re probably better spending your time on gradually refactoring.