Question

I’m working on an app, moving the mouse in a certain area and clicking the mouse if something is not the color black.

However, I am getting a really high CPU usage while using this method too get the color below the cursor. After 5 completed runs from startY to endY – the application is lagging that much it takes around 5-10 sec. to get too the end of the area. With this part commented out, the application runs fine and each run doesn’t increase in the too complete.

Here is my while loop:

private void moveMouse(int startX, int endX, int startY, int endY)
    {
        int newPosX = startX;
        int newPosY = startY;
        while (running)
        {
            Application.DoEvents();
            //this.Cursor = new Cursor(Cursor.Current.Handle);
            Cursor.Position = new Point(newPosX, newPosY);
            Thread.Sleep(3);
            if (colorCursor.Get(newPosX, newPosY))
            {
                MyMouse.sendClick();
                countClicks++;
                lblStatus.Text = "Klik: " + countClicks;
            }

            newPosX += 10;
            if (newPosX > endX)
            {
                newPosY += 25;
                newPosX = startX;
            }
            if (newPosY > endY)
            {
                newPosY = startY;
                Thread.Sleep(1000);
            }
        }
    }

Color below cursor:

public class ColorUnderCursor
{
    [DllImport("gdi32")]
    public static extern uint GetPixel(IntPtr hDC, int XPos, int YPos);

    //[DllImport("user32.dll", CharSet = CharSet.Auto)]
    //public static extern bool GetCursorPos(out POINT pt);

    [DllImport("User32.dll", CharSet = CharSet.Auto)]
    public static extern IntPtr GetWindowDC(IntPtr hWnd);

    public bool Get(int x, int y)
    {
        IntPtr dc = GetWindowDC(IntPtr.Zero);

        long color = GetPixel(dc, x, y);
        Color underMouse = Color.FromArgb((int)color);
        if(underMouse != Color.FromArgb(0, 0, 0, 0))
            return true;

        return false;
    }
}

How I can minimize this heavy usage of the CPU.

Solution:
It was my method "Get" which was causing the problem. I solved it by this method below, and running the whole thing inside a backgroundworker.

public bool GetPixel(Point position)
    {
        using (var bitmap = new Bitmap(1, 1))
        {
            using (var graphics = Graphics.FromImage(bitmap))
            {
                graphics.CopyFromScreen(position, new Point(0, 0), new Size(1, 1));
            }
            if (bitmap.GetPixel(0, 0) != Color.FromArgb(255, 0, 0, 0) && bitmap.GetPixel(0, 0) != Color.FromArgb(255, 255, 255, 255))
                return true;

            return false;
        }
    }

Answer 1

Try to move logic into Invoke call like this

private void moveMouse(int startX, int endX, int startY, int endY)
{

  this.BeginInvoke(new Action(() => { InvokeMouseMove(startX, endX, startY, endY)
   }));
}

private void InvokeMouseMove(int startX, int endX, int startY, int endY)
    {
        int newPosX = startX;
        int newPosY = startY;
        while (running)
        {
            Application.DoEvents();
            //this.Cursor = new Cursor(Cursor.Current.Handle);
            Cursor.Position = new Point(newPosX, newPosY);

            if (colorCursor.Get(newPosX, newPosY))
            {
                MyMouse.sendClick();
                countClicks++;
                lblStatus.Text = "Klik: " + countClicks;
            }

            newPosX += 10;
            if (newPosX > endX)
            {
                newPosY += 25;
                newPosX = startX;
            }
            if (newPosY > endY)
            {
                newPosY = startY;
            }
        }
    }