Question

I’m working on an app that involved comparing to numbers inputted by the user via text box, but wen I put in any if statements the program crashes whenever they are called. Otherwise the program runs just fine without any crashes or errors.

    package improvecredit.app.basic;
    import android.app.Activity;
    import android.os.Bundle;
    import android.view.View;
    import android.text.Editable;
    import android.widget.Button;
    import android.widget.EditText;
    import android.widget.TextView;

public class ImprovrCreditBasicActivity extends Activity {
/** Called when the activity is first created. */
public int minCredScore = 300;
public int maxCredScore = 850;
public int inputScore;
public int idealScore;

public Editable inputString;
public Editable idealString;

public EditText user;
public EditText desired;
public TextView output;

public Button submit;

@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main);

    user = (EditText) findViewById(R.id.user_text);
    desired = (EditText) findViewById(R.id.desired_text);
    output = (TextView) findViewById(R.id.output_text);
    submit = (Button) findViewById(R.id.submit_button); 

    //submit.setOnClickListener(new View.OnClickListener());

    submit.setOnClickListener(new View.OnClickListener() {
        public void onClick(View v) {
            //inputString = user.getText();
            //idealString = desired.getText();

            inputScore = Integer.getInteger(user.getText().toString());
            idealScore = Integer.getInteger(desired.getText().toString());

            if (inputScore >= 0 && idealScore >= 0){

                if (inputScore < minCredScore || idealScore < minCredScore){
                    output.setText("Invalid Entries");
                }
                if (inputScore > maxCredScore || idealScore > maxCredScore){
                    output.setText("Invalid Entries");
                }
                if (inputScore > idealScore){
                    output.setText("Nice Credit Score!");
                }
                if (inputScore < idealScore){
                    output.setText("For more information on how to improve your credit score, please visit" + "/n" + "http://www.creditscoresandcredit.com/");
                }
            }
            else{
                output.setText("Please enter valid credit scores");
            }
        }
    });         
}

If someone can point out what may have been done wrong in the code I would really appreciate it.

Answer 1

On first glance, don’t use Integer.getInteger(), use Integer.parseInt().

If that doesn’t fix it, please include the crash log from the console so we can see exactly what exception is being raised.