Question

I’m writing a stored procedure, but I can’t figure out what’s wrong the compiler wont give me any error specification at all. Just that it says query completed with errors. I cant see the error..?!

This is to be used as a stored procedure that updates two tables, the code itself is pretty self-explanatory.

SET ANSI_NULLS ON
SET QUOTED_IDENTIFIER ON
GO

ALTER PROCEDURE [dbo].[insertRankingData]
@domannamn [varchar](100),
@keyword [varchar](100),
@dagensdatum [Date],
@rankingposition [Decimal]
AS
DECLARE @domanID int 
DECLARE @datumen date 

IF(SELECT COUNT(*) FROM [dbo].[t_doman] WHERE doman_namn = @domannamn) = 0
BEGIN
INSERT INTO [dbo].[t_doman] (doman_namn) 
    VALUES(@domannamn)

    SELECT @domanID = SCOPE_IDENTITY()
SELECT @todaysdate = GETDATE()
END
ELSE
BEGIN
SELECT @domanID = [doman_id] 
    FROM [dbo].[t_doman] 
    WHERE doman_namn = @domannamn

SELECT @todaysdate = GETDATE()
END

IF NOT @domanID IS NULL
BEGIN 
IF NOT EXISTS (SELECT (ranking_date, ranking_keyword, ranking_id_doman) 
                    FROM [dbo].[t_ranking] 
                    WHERE ranking_id_doman = @domanID
                    AND ranking_keyword = @keyword
                    AND ranking_date = @datumen)
BEGIN

       INSERT INTO [dbo].[t_ranking] (ranking_id_doman, ranking_date, ranking_position, ranking_keyword) 
       VALUES(@domanID, @todaysdate, @rankingposition, @keyword)    
END
ELSE
BEGIN 
       UPDATE [dbo].[t_ranking] 
       SET ranking_position = @rankingposition
       WHERE ranking_date = @todaysdate
       AND ranking_keyword = @keyword
       AND ranking_id_doman = @domanID 
END
  END

Answer 1

Try this:

ALTER PROCEDURE [dbo].[insertRankingData]
@domannamn [varchar](100),
@keyword [varchar](100),
@dagensdatum [Date],
@rankingposition [Decimal]
AS
DECLARE @domanID int 
DECLARE @datumen date 
IF EXISTS(SELECT 1 FROM [dbo].[t_doman] WHERE doman_namn = @domannamn)
BEGIN
INSERT INTO [dbo].[t_doman] (doman_namn) VALUES(@domannamn)
SELECT @domanID = SCOPE_IDENTITY()
SELECT @todaysdate = GETDATE()
END
ELSE
BEGIN
SELECT @domanID = [doman_id] FROM [dbo].[t_doman] WHERE doman_namn = @domannamn
SELECT @todaysdate = GETDATE()
END
IF @domanID IS NOT NULL
BEGIN 
IF NOT EXISTS (SELECT ranking_date, ranking_keyword, ranking_id_doman
                    FROM [dbo].[t_ranking] 
                    WHERE ranking_id_doman = @domanID
                    AND ranking_keyword = @keyword
                    AND ranking_date = @datumen)
BEGIN
INSERT INTO [dbo].[t_ranking] (ranking_id_doman, ranking_date, ranking_position, ranking_keyword) 
    VALUES(@domanID, @todaysdate, @rankingposition, @keyword)   
END
ELSE
BEGIN 
    UPDATE [dbo].[t_ranking] 
    SET ranking_position = @rankingposition
    WHERE ranking_date = @todaysdate
    AND ranking_keyword = @keyword
    AND ranking_id_doman = @domanID 
END
  END

Hope this Helps!!