Question

I’m writing an Android app and I have a class that generates and maintains some fixed URL’s that can occasionally change. I keep them all in one class called UrlUtils:

public class UrlUtils {
  private static String sUrlBase = "http://google.com";

  /**
   * Called occasionally
   */
  public static void refreshUrlBases() {
        sUrlBase = "http://yahoo.com/" + new Random().nextInt();
  }

   public static String getUrlBase() {
        return sUrlBase;
   }
}

I have to make a lot of calls to getUrlBase() above, so I was thinking about making sUrlBase public and access it directly. Will this approach be better in terms of performance?

Answer 1

If you are not going to change your url more frequently, then instead of getter/setter method I will say that you can keep static directly

public static String google_url = "http://google.com";
public static String yahoo_url  = "http://yahoo.com";

In keeping static method, it may happen that due to some problem static setter values are removed(reset to original). So, in that case it will return you the original constant of static value.

UPDATE:

If your are going to update your URL dynamically then static method would prove to be better option.

    public static String sUrlBase = "http://google.com"; 

    public static String getsUrlBase() {
        return sUrlBase;
    }
    public static void setsUrlBase(String sUrlBase) {
        this.sUrlBase = sUrlBase;
    }