Question

Image a Button on your windows form that does something when being clicked.

The click events thats raised is typically bound to a method such as

protected void Button1_Click(object sender, EventArgs e) {

}

What I see sometimes in other peoples’ code is that the implementation of the buttons’ behaviour is not put into the Button1_Click method but into an own method that is called from here like so:

private DoStuff() { }

protected void Button1_Click(object sender, EventArgs e) { this.DoStuff(); }

Although I see the advantage here (for instance if this piece of code is needed internally somewhere else, it can be easily used), I am wondering, if this is a general good design decision?

So the question is: Is it a generally good idea to put event handling code into an own method and if so what naming convention for those methods are proven to be best practice?

Answer 1

I put the event handling code into a separate method if:

• The code is to be called by multiple events or from anywhere else or
• The code does not actually have to do with the GUI and is more like back-end work.

Everything small and only GUI-related goes always into the handler, sometimes even if it is being called from the same event (as long as the signature is the same). So it’s more like, use a separate method if it is a general action, and don’t if the method is closely related to the actual event.