Question

In a PHP project I am working on right now, I have some code similar to this:

$allVarsTrue = TRUE;

if ($foo && $bar) {
  for ($x=1;$x<=5;$x++) {
    if (!somerandomtest($x)) {
      $allVarsTrue = FALSE; // if $x fails the test, $allVarsTrue is set to false
    }
  }
} else { // if either $foo and $bar is false, $allVarsTrue is set to false
  $allVarsTrue = FALSE; 
}

if ($allVarsTrue) {
  echo "True";
} else {
  echo "False";
}

I would like to write this more succinctly, something like this

// This code does not work.
if ($foo &&
    $bar &&
    for ($x=1;$x<=5;$x++) {
      somerandomtest($x);
    }) {
  echo "True";
} else {
  echo "False";
}

How can I rewrite the existing code more succinctly?

Answer 1

One option is to move your loop into its own function:

function performTests() {
  for(…) { if(!test(…)) return FALSE; } # return early, no need to iterate over remaining items
  return TRUE;
}

if($foo && $bar && performTests()) {
  …
} else {
  …
}