Question

In java/groovy application I am using org.slf4j.Logger
I like to log method execution time and proposing to use following code

def startTime
LOGGER.isDebugEnabled() {
    startTime = System.currentTimeMillis()
}

doSomething()

LOGGER.debug("Execution took {}ms", (System.currentTimeMillis() - startTime))

I think this code is ‘ugly’.
Can anyone suggest something more elegant ?

Answer 1

If you want to make the code look less ugly:

Change

def startTime
LOGGER.isDebugEnabled() {
    startTime = System.currentTimeMillis()
}

to

def startTime = System.currentTimeMillis()

I am not a fan of isDebugEnabled for these one liners. You will not see any performance difference without it.