Question

In my Firefox extension, I create a popup menu dynamically. Originally, I used this line on each menu item:

menuFunc.setAttribute("oncommand","MainExtension.MyPlugin." + functionName + "();");

where functionName is a string with the name of the function to be called for that menu item. This worked fine. When I uploaded my extension to the Mozilla Addons page, the automated code validation program flagged this line and said that using setAttribute to set oncommand in this way was not secure and that addEventListener should be used instead. I switched to this syntax:

menuFunc.addEventListener("oncommand",function() {MainExtension.MyPlugin[functionName]},false);

but now nothing happens when I click on a menu item.

Is my syntax off or is there something else wrong? I don’t think the problem is the common ‘this’ reference error. I tried removing all uses of ‘this’ from one of the functions and it still did not work. It seems like the functions are not being called at all. No errors are being generated either.

Answer 1

Update:

The command action is attached using just command, not oncommand:

menuFunc.addEventListener("command", MainExtension.MyPlugin[functionName], false);

---

You should be able to just do:

menuFunc.oncommand = MainExtension.MyPlugin[functionName];