Home/ Questions/Q 3974168
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-20T04:32:11+00:00

In my multi-layer application, a data access layer reads the database and returns SqlDataReader

  • 0

In my multi-layer application, a data access layer reads the database and returns SqlDataReader for collections of objects and SqlDataRecord for a single object to a business layer. A business layer has constructors that initialize either a SqlDataReader or SqlDataRecord. That seemed a natural design to follow, however I run into multiple problems with readers going out of scope and multiple concurrent readers. What is a better way to tackle this design ? Is it better to make a data layer return a dictionary of fields and dispose readers immediately? And is it better to use DataSets in place where streaming of data is not required?

Some examples of exceptions that I encounter in my application:
– Invalid attempt to call MetaData when reader is closed
– There is already an open DataReader associated with this Command which must be closed first

EDIT: found an excellent article Contrasting the ADO.NET DataReader and DataSet. Going to use DataSets whenever appropriate (disconnected, buffered approach).

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    You definitely want to close the SqlDataReader connections as soon as possible. The SqlDataReader is very fast but when they remain open you are using up one of you connection pool connections. This could easily put you in a condition where you have resource issues, as you mentioned.

    I would not, as you suggested, pass a SqlDataReader to the business tier. I would either fill up a DataSet and pass that or construct a custom data entity object and return that to the business tier.

    • 0