Question

In the last few days I am trying to get data from my SQL table and get it into my textbox.

The table name : “check”.

The code I am using :

SqlDataReader myReader = null;

connection = new SqlConnection(System.Configuration.ConfigurationManager
                    .ConnectionStrings["ConnectionString"].ConnectionString);
connection.Open();

var command = new SqlCommand("SELECT * FROM [check]", connection);
myReader = command.ExecuteReader();
while (myReader.Read())
{
    TextBox1.Text = myReader.ToString();
}
connection.Close();

I am getting nothing as a result. Anyone know why? Maybe I am not calling the SQL correctly?

Answer 1

using (var connection = new SqlConnection(System.Configuration.ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString))
using (var command = connection.CreateCommand())
{
    command.CommandText = "SELECT ColumnName FROM [check]";
    connection.Open();
    using (var reader = command.ExecuteReader())
    {
        while (reader.Read())
            TextBox1.Text = reader["ColumnName"].ToString();
    }
}

Some comments:

• don’t use *, specify only those fields that you need
• use using – less code, guaranteed disposal
• I assume this is a test program, otherwise it does not make sense to reset Text to a in the loop