Question

In the script below I check if the email entered is valid. It is not the best regex but it is ok for now. Also for the moment I do not make any server side check for input. Only with this script.

I have this problem though:
When an email is valid, and after I type an invalid email I get first the Your email is not in valid format and then You will be notified when we launch. Thank you! alert. Also the email is sent. How to fix this ?

Thank you

this is my form

<form id="myform" action="" method="POST">
                <input id="subscribe" name="subscribe" class="subscribe floatLeft" type="text">
                <button id="signUp" class="signUp floatRight" ><intro>notify!</intro></button>              
                <div class="clear">&nbsp;</div>
</form>

and here is the script

var signUp = function(inputEmail) {
    var isValid = true;
    var emailReg = /^([\w-\.]+@([\w-]+\.)+[\w-]{2,4})?$/;
    if (!emailReg.test(inputEmail)) {
        isValid = false;
        alert('Your email is not in valid format');
    }



$("#myform").submit(function(event) {
    event.preventDefault();
    if (!isValid) {
        return false;
    } else {
        $.post('mailme.php', $("#myform").serialize(), function(data) {
            alert('You will be notified when we launch. Thank you!');

        });
        return false;
    }
});

};

Answer 1

You need the onsubmit event to return false;
You need to bind the submit event anyway and make the isValid check there;

$("#myform").submit(function(event){
  event.preventDefault();
  if(!isValid){
  return false;
 }else{
  $.post(...)
  return false;
 }
});

–Edit–
Forgot to return false/event.preventDefault; But like i said, the submit event need to be bound anyway

–Edit2–

function validEmail(email){
var emailReg = /^([\w-\.]+@([\w-]+\.)+[\w-]{2,4})?$/;
return email.test(emailReg)
}
$(document).ready(function(){
  $("#myform").bind({
    submit: function(e){
     e.preventDefault();
     if(validEmail($("#myform").find("#subscribe").val()){
       $.post(...)
          alert("You will be notified");
         return false;
     }
     else {
        alert("Invalid email");
        return false;
     }

   });

});
}