Question

In this following code whenever I send any command like dir or anything this function get stuck in while loop.
I want the output of the command prompt each time I send it command to execute without closing the process after the execution of command.

public void shell(String cmd)
{
        ProcessStartInfo PSI = new ProcessStartInfo();
        PSI.FileName = "c:\\windows\\system32\\cmd.exe";
        PSI.RedirectStandardInput = true;
        PSI.RedirectStandardOutput = true;
        PSI.RedirectStandardError = true;
        PSI.UseShellExecute = false;
        Process p = Process.Start(PSI);
        StreamWriter CSW = p.StandardInput;
        StreamReader CSR = p.StandardOutput;
        CSW.WriteLine(cmd);
        CSW.Flush();
        while(!(CSR.EndOfStream))
        {
            Console.WriteLine(CSR.ReadLine());
        }

        CSR.Close();

}

Following is the complete code :-

 namespace ConsoleApplication8
 {

     class Program
     {
         public static void shell(String cmd)
         {

             ProcessStartInfo PSI = new ProcessStartInfo();
             PSI.FileName = "c:\\windows\\system32\\cmd.exe";
             PSI.RedirectStandardInput = true;
             PSI.RedirectStandardOutput = true;
             PSI.RedirectStandardError = true;
             PSI.UseShellExecute = false;
             Process p = Process.Start(PSI);
             StreamWriter CSW = p.StandardInput;
             StreamReader CSR = p.StandardOutput;
             CSW.WriteLine(cmd);
             CSW.Flush();
             while (!(CSR.EndOfStream))
             {
                 Console.WriteLine(CSR.ReadLine());
             }

             CSR.Close();

         }
         static void Main(string[] args)
         {
             string cmd="";
             while (cmd != "exit")
             {
            cmd=Console.ReadLine();
            shell(cmd);
             }
         }
     }
 }

Purpose –> I want to create a program that gives user access to execute commands of command prompt. Above program create cmd.exe process each time it sends some command. But that is not a great problem. I can easily fix that.. The main problem is that each time I send a command the program get stuck at while (!(CSR.EndOfStream))

Answer 1

You can try with this code

         ProcessStartInfo PSI = new ProcessStartInfo();
         PSI.FileName = "c:\\windows\\system32\\cmd.exe";
         //PSI.RedirectStandardInput = true;
         PSI.RedirectStandardOutput = true;
         PSI.RedirectStandardError = true;
         PSI.UseShellExecute = false;
         Process p = Process.Start(PSI);
         StreamWriter CSW = p.StandardInput;

         string output = p.StandardOutput.ReadToEnd(); 

         Console.WriteLine(output);