Question

#include "stdio.h"
#include "conio.h"
#include <iostream>

using namespace std;

int main (void) 
{
    char my_char[] = "happy birthday";

    int i;

    bool j=false;
    char my_char_temp[1];

    do
    {
        for (i=0;i<sizeof(my_char)-2;i++)
        {
            j=false;
            if (my_char[i+1] < my_char[i])
            {
                my_char_temp[0]=my_char[i+1];
                my_char[i+1] = my_char[i];
                my_char[i] =  my_char_temp[0];
                j=true;
            }
        }

    }while (j);

    cout << my_char;
}

What am I doing wrong?

I’m just trying to sort the letters within the char.

The output I get is completely wrong.

Answer 1

You are resetting j to false each and every time you compare two characters.

This means that, if you swap two characters, and you are NOT at the end of your array, you will forget that you have swapped them.

Move the j=false; from inside the for-loop to just inside the do-loop.

And you owe me a bottle of Jack for saving your ass on a homework assignment on Sunday afternoon.