Question

#include <stdio.h>  
#include <ctype.h>  
#define STRING_LEN 500         
void stripspaces(char, char, char);


int main(void)  
{  
   char string[STRING_LEN];         
   char *p1 = string;          
   char *p2 = string;

   printf("Enter a string of up to %d characters:\n", STRING_LEN);  
   while((*p1++ = getchar()) != '\n') ; 

  stripspaces(string, *p1, *p2); 

  getch();  
  return 0;
}  
void stripspaces (char s, char *x1, char *x2){ 
   *x1 = '\0';                 
   x1 = s;                
   while(*x1 != '\0')    
   {  
     if(ispunct(*x1) || isspace(*x1))  
     {                    
       ++x1;              
       continue;  
     }  
     else  
       *x2++ = *x1++;   
   }  
   *x2 = '\0';          
   printf("\nWith the spaces removed, the string is now:\n%s\n", s);  
}

This code is bringing up the following error at the ‘stripspaces‘ function; “passing arg 1 of ‘stripspaces‘ makes integer from pointer without a cast” any help would be excellent.

In case it is not obvious from the code, the program should take in a string and remove all the spaces from it. The function has to remain although I know I can do it without the function.

Answer 1

Your prototype and function definition don’t match:

void stripspaces(char, char, char);

vs.

void stripspaces (char s, char *x1, char *x2)

You should change the prototype to

void stripspaces(char, char*, char*);

And in order to make them both work, you should use

void stripspaces(char*, char*, char*);

and

void stripspaces (char *s, char *x1, char *x2)

.

For easier copy & paste, you can use parameter names in the prototype as well.