Question

Inside of a public class:

    public static class LogReporting

I have the following method:

    public void RunTimerJobs()
    {
        SPAdministrationWebApplication centralAdmin = SPAdministrationWebApplication.Local;
        try
        {
            foreach (SPService service in centralAdmin.Farm.Services)
            {
                Guid traceGuid = new Guid("d3beda82-38f4-4bc7-874f-ad45cebc9b35");
                Guid eventGuid = new Guid("3ea057b3-0391-4c33-ac8d-412aecdda97d");

                var traceJob =
                    from jobDefinition in service.JobDefinitions
                    where jobDefinition.Id == traceGuid
                    select jobDefinition;

                if (traceJob != null && traceJob.Count() == 1)
                {
                    traceJob.First().RunNow();
                }

                var eventJob =
                    from jobDefinition in service.JobDefinitions
                    where jobDefinition.Id == eventGuid
                    select jobDefinition;

                if (eventJob != null && eventJob.Count() == 1)
                {
                    eventJob.First().RunNow();
                }
            }
        }
        catch (Exception ex)
        {
            //Loggers.SharePointLogger logger = new Loggers.SharePointLogger();
            //logger.WriteTrace(ex.Message, LogProduct.MonitoringView, LogTraceSeverity.Unexpected);
        }

However it will not allow me to compile citing that RunTimerJobs() “cannot declare instance members in a static class”
To my knowledge, none of the ‘instance members’ I declare are able to be labeled as static, so is there just a fundamental issue with the setup (i.e. a static class) or am I missing some little snippet?

Answer 1

Your class is static thus you cannot have any instance members because you will never instantiate the class.

To be able to use the RunTimerJobs() method you would need to create an instance of the LogReporting class, i.e.

LogReporting logReporting = new LogReporting();
logReporting.RunTimerJobs();

This obviously won’t work though because your class is defined as static and you cannot create instances of it.

Either make your method static or remove the static keyword from your class declaration – depending on what you require.

I see no instance related logic in your method so it should be safe to mark it as static.

Remember

Classes can have a mixture of instance and static members as long as the class isn’t marked static.

And

Only mark classes as static when you know that ALL members (properties, methods etc…) will be static as well.