Question

Is it acceptable/good-style to simplify this function:

bool TryDo(Class1 obj, SomeEnum type)
{
    if (obj.CanDo(type))
    {
        return Do(obj);
    }
    else
    {
        return false;
    }
}

as:

bool TryDo(Class1 obj, SomeEnum type)
{
    return obj.CanDo(type) && Do(obj);
}

The second version is shorter but arguably less intuitive.

Answer 1

What I would code is :

return obj.CanDo(type) ? Do(obj) : false;