Question

Is it safe for a thread to READ a variable set by a Delphi VCL event?

When a user clicks on a VCL TCheckbox, the main thread sets a boolean to the checkbox’s Checked state.

CheckboxState := CheckBox1.Checked;

At any time, a thread reads that variable

if CheckBoxState then ...

It doesn’t matter if the thread “misses” a change to the boolean, because the thread checks the variable in a loop as it does other things. So it will see the state change eventually…

Is this safe? Or do I need special code? Is surrounding the read and write of the variable (in the thread and main thread respectively) with critical code calls necessary and sufficient?

As I said, it doesn’t matter if the thread gets the “wrong” value, but I keep thinking that there might be a low-level problem if one thread tries to read a variable while the main thread is in the middle of writing it, or vice versa.

My question is similar to this one: Cross thread reading of a variable who's value is not considered important.

(Also related to my previous question: Using EnterCriticalSection in Thread to update VCL label)

Answer 1

This is safe, for three reasons:

• Only one thread writes to the variable.

• The variable is only one byte, so there is no way to read an inconsistent value. It will be read either as True or as False. There can’t be alignment issues with Delphi boolean values.

• The Delphi compiler does no extensive checks whether a variable is actually written to, and does not “optimize” away any code if not. Non-local variables will always be read, there is no need for the volatile specifier.

Having said that, if you are really unsure about this you could use an integer value instead of the boolean, and use the InterlockedExchange() function to write to the variable. This is overkill here, but it’s a good technique to know about, because for single machine word sized values it may eliminate the need for locks.

You can also replace the boolean by a proper synchronization primitive, like an event, and have the thread block on that – this would help you eliminate busy loops in the thread.