Question

Is there a better, more concise way to do this:

function getTweets(){
                $.getJSON("http://search.twitter.com/search.json?callback=?&q=superfad",

                function(data){
                    tweetsLoaded = true;
                    $.each(data.results, function(i,item){
                        var textPlain = item.text;
                        var textLinked = linkify(textPlain);
                        var textHashed = hashify(textLinked);
                        var textListed = listify(textHashed);

                        function linkify(tweet){
                            return tweet.replace(/(http:\/\/[^\s]*)/g, "<a class='twtr-link' target=\"_blank\" href=\"$1\">$1</a>");
                        }

                        function hashify(tweet){
                            return tweet.replace(/(^|\s+)#(\w+)/gi, function(m, before, hash) {
                                return before + '<a target="_blank" class="twtr-hashtag" href="http://twitter.com/search?q=%23' + hash + '">#' + hash + '</a>';
                              });
                        }

                        function listify(tweet) {
                            return tweet.replace(/\B[@＠]([a-zA-Z0-9_]{1,20})/g, function(m, username) {
                                return '<a target="_blank" class="twtr-atreply" href="http://twitter.com/intent/user?screen_name=' + username + '">@' + username + '</a>';
                            });
                        }

                        $("#twitter_results").append('<li class="twitter"><img class="twitter_img" src="' + item.profile_image_url + '"/>'+ textListed + '</li>');
                    });
                });
            } //end getTweets

Answer 1

// define this globally
function stuffify(match, group1, group2) {
  switch (group1 || group2) {
    case 'http':
      return '<a class="twtr-link" target="_blank" href="' + match + '">' + match + '</a>';
    case '#':
      return '<a class="twtr-hashtag" target="_blank" href="http://twitter.com/search?q=' + encodeURIComponent(match) + '">#' + match + '</a>'

    case '@':
      return '<a class="twtr-atreply" target="_blank" href="http://twitter.com/intent/user?screen_name=' +  encodeURIComponent(match) + '">@' + match + '</a>';
    default: 
      return match;
  }
}

function(data){
  tweetsLoaded = true;
  var interestingParts = /(http):\/\/\S+|(#|@)[^\s.,!?;^()\[\]<>{}]+/g;

  $.each(data.results, function(i,item) {
    var newText = item.text.replace(interestingParts, stuffify);

    $("#twitter_results").append('<li class="twitter"><img class="twitter_img" src="' + item.profile_image_url + '"/>'+ newText + '</li>');
  });
}