Question

Is there any functionality in magento payment extention to stop the creation of an order before the success status from payment gateway is returned?

The Extension is designed as a payment redirect (with getOrderPlaceRedirectUrl) but really in the correct controller action, I do post from the action with params, to the gateway and return success if all OK, and return failure if not.

But the order is already created so I must cancel this order, but it should not create this order in the first place.

Maybe if I can design it as a gateway, I can use some payment method to do this?

I thought about the validate or prepareSave methods, but both of them are called twice – on accept payment method and on place order.

Also I thought about events – maybe I can use some event to do this post action and on failture just throw exception?

But I really think that in the payment methods, there has to be some standard functionality that I can use.

Answer 1

How about extending the _validate() method on Mage_Sales_Model_Service_Quote, and throw an error there so that it never gets to the “$transaction->save();” bit.

public function submitOrder()
    {
        $this->_deleteNominalItems();
        // do some check here
        $this->_validate();
        // End checks
        $quote = $this->_quote;
        $isVirtual = $quote->isVirtual();

        ........

        try {
            $transaction->save();
            $this->_inactivateQuote();
            Mage::dispatchEvent('sales_model_service_quote_submit_success', array('order'=>$order, 'quote'=>$quote));
        } catch (Exception $e) {
            ...........
        }
        ...........
        return $order;
    }

Validate function looks like this:

protected function _validate()
{
    $helper = Mage::helper('sales');
    if (!$this->getQuote()->isVirtual()) {
        $address = $this->getQuote()->getShippingAddress();
        $addressValidation = $address->validate();
        if ($addressValidation !== true) {
            Mage::throwException(
                $helper->__('Please check shipping address information. %s', implode(' ', $addressValidation))
            );
        }
        $method= $address->getShippingMethod();
        $rate  = $address->getShippingRateByCode($method);
        if (!$this->getQuote()->isVirtual() && (!$method || !$rate)) {
            Mage::throwException($helper->__('Please specify a shipping method.'));
        }
    }

    $addressValidation = $this->getQuote()->getBillingAddress()->validate();
    if ($addressValidation !== true) {
        Mage::throwException(
            $helper->__('Please check billing address information. %s', implode(' ', $addressValidation))
        );
    }

    if (!($this->getQuote()->getPayment()->getMethod())) {
        Mage::throwException($helper->__('Please select a valid payment method.'));
    }

    return $this;
}

The extended function can look like this:

    public function __construct(Mage_Sales_Model_Quote $quote)
    {
        $this->_quote = $quote;
        parent::__construct($quote);
    }

protected function _validate()
    {
        // Code to test comes here
        Mage::throwException(Mage::helper('payment')->__('unsuccessfull.....'));
        // Code ends, now call parent

        return parent::_validate();        

    }