Sign Up to our social questions and Answers Engine to ask questions, answer people’s questions, and connect with other people.
Login to our social questions & Answers Engine to ask questions answer people’s questions & connect with other people.
Lost your password? Please enter your email address. You will receive a link and will create a new password via email.
Please briefly explain why you feel this question should be reported.
Please briefly explain why you feel this answer should be reported.
Please briefly explain why you feel this user should be reported.
Is there anything (anti-pattern) that should prevent me from making an async version of an API call like this?
public IItem GetItem(int id)
{
var result = SomeLengthyServiceCall(id);
return result;
}
public async Task<IItem> GetItemAsync(int id)
{
return await Task.Run(() => this.GetItem(id));
}
Yes, that is an anti-pattern; see Stephen Toub’s excellent blog post on asynchronous wrappers for synchronous methods.
In short, only naturally-asynchronous methods should have asynchronous APIs.