Question

Is this a problem / bad practice:
I have the same method names in both Model and Controller. For example:

In the Director Model:
function approve($company_id, $director_id){….}

In the DirectorsController:
function approve($id = null){…}

The reason to have these are for clarity (I know it looks confusing instead, but for this particular application, this makes it much clearer.)

Currently it is working, but I am not sure if this is fine.

Thank you for any input.

Answer 1

If you understand how OOP works you’d know this would pose no problem, since one method is called in the model and the other in the controller which are separate objects.

If you do $this->approve() in your controller it would be different than doing $this->Model->approve() in the controller. You should be fine