Question

Is this code good enough:

if (MyCollection.Where(p => p.SomeID == idstring).Any())
{
   selectedval = MyCollection.Where(p => p.SomeID == idstring).FirstOrDefault().MyField;
}

My doubt is about the fact that I make the same query twice: first for null check and then to actually get data.

Maybe there is a better way to do this type of things?

Answer 1

Yes.

var item = MyCollection.FirstOrDefault(p => p.SomeID == idstring);
if (item != null)
    selectval = item.MyField;

This avoids double querying the collection, which will certainly make a difference in big collections or if your collection performs a DB query.