Question

Is this the best way to write this if else code checking?

// set the default to Italy if countrySaved is null
if (lang == NULL) {
    lang = @"it";
}

// otherwise set the correct lang based on the country chosed and saved in nsuserdefaults
if ([countrySaved isEqual:@"Brazil"]) {
    lang = @"br";
}

else if ([countrySaved isEqual:@"Spain"]) {
    lang = @"es";
}

else if ([countrySaved isEqual:@"Italy"]) {
    lang = @"it";
}

else if ([countrySaved isEqual:@"United States"]) {
    lang = @"us";
}

else if ([countrySaved isEqual:@"United Kingdom"]) {
    lang = @"uk";
}

thanks for any help

Answer 1

Store the language IDs in a dictionary:

NSDictionary *languageIDs = @{
    @"Brazil" : @"br",
    @"Spain" : @"es",
    @"Italy" : @"it",
    @"United States" : @"us",
    @"United Kingdom" : @"uk"
};

Then simply assign lang from said dictionary:

lang = languageIDs[countrySaved];

if (!lang) {
    lang = languageIDs[@"Italy"];
}

Or the shorter way I’d do it using a ternary operator:

lang = languageIDs[countrySaved] ?: languageIDs[@"Italy"];

---

Also you should probably either load them from a plist file or use NSString consts in order to avoid eventually redundant and by that unmaintainable literals scattered all over your code.