Question

It has come to my attention that the redirect controller method is not working part of the time. No message appears when I set debug > 0. I don’t echo any code before calling the redirect method so it shouldn’t be because of “headers already sent”.

Let’s take a look at my ArticlesController add action where redirect works in one instance but not in another.

public function add($page = null) {
    // Custom component to get if user has required access level
    // of page to write an article. If not, setflash to an error message
    // specific to user's access level and redirect.

    $access_message = $this->CustomPage->AccessMessage(4, $this->viewVars['access']);

    if($access_message){

        // Flash works but redirect does not
        $this->Session->setFlash(__($access_message));
        $this->redirect(array('action' => 'index', 'page' => $page));
        // Also tried
        // $this->redirect(array('controller'=>'articles', 'action' => 'index', 'page' => $page), null, true);
    } else
    {

    if ($this->request->is('post')) {

        $this->Article->create();
                if ($this->Article->save($this->request->data)) {

                    // BLAH BLAH save post, do other stuff
                    // BLAH BLAH save post, do other stuff

                    // This flash and redirect works
                    $this->Session->setFlash(__('The article has been saved'));
                    $this->redirect(array('action' => 'view', 'id' => $article_id, 'page' => $page));

                    } else {
                    $this->Session->setFlash(__('The article could not be saved. Please, try again.'));
                    } // end else if article cannot be saved
        } // if method is post
    } // end if user has access
} // end add action

It definitely has something to do with the component but I’m not sure what. Maybe since redirect is called right after the component is used, the “$this” is trying to do the redirect method on the component instead of the controller. I tried $this->Article->redirect and reloading the Article model before the redirect but neither of those worked.

My component code is:

public function AccessMessage($required_level, $user_level) {

    if(!$user_level && $this->_View->viewVars['access']){
        $user_level = $this->_View->viewVars['access'];
    }

    if(!$required_level || !$user_level || $user_level != $required_level){
        $accessModel = ClassRegistry::init('Access');
        $access_message = $accessModel->field('access_message', array('Access.id' => $required_level));
     }

      return $access_message;
}

Edit 1: Ok so I did some digging to find exactly where the problem is stemming from. The USE of the component is not the problem which I thought it was before. If all I have in my component is

public function AccessMessage($required_level, $user_level) {

    if(!$user_level && $this->_View->viewVars['access']){
        $user_level = $this->_View->viewVars['access'];
    }

    if(!$required_level || !$user_level || $user_level != $required_level){
        $access_message = 1;
     }

      return $access_message;
}

Then it works. The issue is with these two lines which are correctly implemented because they return the value for $access_message I am expecting, but they are interfering with the ability to redirect. Perhaps headers are already sent out?

        $accessModel = ClassRegistry::init('Access');
        $access_message = $accessModel->field('access_message', array('Access.id' => $required_level));

Please note I have also tried:

        $access_message = ClassRegistry::init('Access')->field('access_message', array('Access.id' => $required_level));

And

        $this->loadModel('Access');
        $access_message = $this->Access->field('access_message', array('Access.id' => $required_level));

Gists:

component gist: https://gist.github.com/970a951715205c222348

controller gist: https://gist.github.com/2b90e5af2518a81672fb

access model gist: https://gist.github.com/bhndbrwneyes/f333a93f0a21302d832f

Answer 1

You may have space before/after php Opening/Closing tags in controller and models. Remove all the closing tags from all controllers and models and any whitespace before opening tags. Then check the result.