Question

It is important to me that my syntax does not make other developers confused.

In this example, I need to know if a parameter is a certain type.

I have hit this before; what’s the most elegant, clear approach to test “not is”?

Method 1:

void MyBinding_Executed(object sender, ExecutedRoutedEventArgs e)
{
    if (!(e.parameter is MyClass)) { /* do something */ }
}

Method 2:

void MyBinding_Executed(object sender, ExecutedRoutedEventArgs e)
{
    if (e.parameter is MyClass) { } else { /* do something */ }
}

Method 3:

void MyBinding_Executed(object sender, ExecutedRoutedEventArgs e)
{
    var _Parameter = e.parameter as MyClass;
    if (_Parameter != null) { /* do something */ }
}

Method 4:

void MyBinding_Executed(object sender, ExecutedRoutedEventArgs e)
{
    var _Type = typeof(MyClass);
    switch (e.parameter.GetType())
    { 
      case _Type: /* do nothing */; break;
      default: /* do something */; break;
    }
}

[EDIT] Method 5:

void MyBinding_Executed(object sender, ExecutedRoutedEventArgs e)
{
    if ((e.parameter is MyClass) == false) { /* do something */ }
}

Which is the most straight-forward approach?

Answer 1

I would go for 3 if you need the variable later or 1 if you don’t need the variable.
2 is ugly because of the empty block.

However I think they all are straight-forward.