Question

It is strange, I coded my pig game here in c++ which once the user or computer reaches 100 he wins. But the problem is if I keep rolling and I go past 100 I don’t win unless I hold after I get there. And the computer if it gets close to 100 around 80 to 100 it will just say it wins. I don’t understand whats going on here and what the problem is? I did everything right! Or am I missing something?

How can I fix this issue where once I reach 100 rolling or holding on the users end that it just wins and doesn’t go past 100 so if I hold at 100+ it tells me I win. How can I go about making it so the computer only wins when it actually gets to 100 or past it automatically?

Answer 1

Try it this way :

            do
            {
               if((humanTotalScore < 100) && (computerTotalScore < 100))
               continuePlay = true;
               else
               continuePlay = false;

                {

                    humanTurn(humanTotalScore);
                    computerTurn(computerTotalScore);
                }


                if(humanTotalScore >= 100)
                {
                    cout << "You won!";
                    return 0;
                }
                else if (computerTotalScore >= 100)   
                {

                    cout << "You lost!";
                    return 0;
                } 
           }
             while(continuePlay == true);

and

int computerTurn(int& computerTotalScore)
    {
            int currentScore = 0;
            int randomDiceRoll;
            cout << " " << endl;
            cout << "The computer will now make its move" << endl;
            cout << " " << endl;
            while ((currentScore < 20) && (computerScore != 1)&&computerTotalScore<100)
            {
                    randomDiceRoll = diceRollFunction();
                    if (randomDiceRoll == 1)
                    {
                            cout << "The computer rolled: ";
                            cout << randomDiceRoll;
                            cout << " " << endl;
                            cout << "The computers total score is: " << computerTotalScore;
                            cout << " " << endl;
                            cout << " " << endl;
                            cout << "The computer has rolled a one, it is now your turn." << endl;
                            cout << " " << endl;

                            break;
                    }
                    else
                    {
                            currentScore += randomDiceRoll;
                            computerTotalScore += randomDiceRoll;
                            cout << "The computer rolled: ";
                            cout << randomDiceRoll;
                            cout << " " << endl;
                            cout << "The computers total score is: " << computerTotalScore;
                            cout << " " << endl;
                            cout << " " << endl;
                    }
            }
            if(currentScore >= 20)
            {
                    computerTotalScore += computerScore;
                    cout << "The computer has reached a max of 20 points for their turn" << endl;
                    cout << " " << endl;
            }

            return computerTotalScore;
    }

changes made :

• The if condition was altered due to flaw in logic.
• The If condition,if((humanTotalScore < 100) && (computerTotalScore < 100)) was moved into the do-while loop. Since it have to be updated each time anyone plays.
• The function int computerTurn(int& computerTotalScore) was altered,In some places computerScore was used instead of computerTotalScore