Question

It’s Rails/Ruby. Just wondering if there is a DRYer version to remove the repetition in the following code:

case params[:order]
when 'rating_ascend'
  order = {:order => 'rating_average ASC'}
when 'rating_descend'
  order = {:order => 'rating_average DESC'}
when 'distance'
  order = {:order => 'distance ASC'}
else
  order = {:order => 'distance ASC'}
end

Thanks.

Answer 1

Or course, there is.

order = case params[:order]
  when 'rating_ascend'
    {:order => 'rating_average ASC'}
  when 'rating_descend'
    {:order => 'rating_average DESC'}
  else
    {:order => 'distance ASC'}
end

Or even this (I wouldn’t write like this, but this is DRYer)

order = {:order => case params[:order]
  when 'rating_ascend' then 'rating_average ASC'
  when 'rating_descend' then 'rating_average DESC'
  else 'distance ASC'
end}

When you simplify code to this point, you notice that you have double “distance ASC” result. Is it a typo or intentional?