Question

I’ve a form that navigates webpage and access data. It looks like something below.

 private void LoginButton_Click(object sender, EventArgs e)
    {
        if(LoginButton.Text == Login)
        {
                LoginButton.Text = "Logging in...";
                ....
                ...
                Login process goes here...
                ..
                if(Login Successed)
                {
                    LoginButton.Text ="Download";
                }
                else
                {
                    LoginButton.Text = "Login";
                }
        }
        else if(LoginButton.Text==Download)
        {
            Download data here...
        }
    }

Same button(And same event too), doing two process and seems like different events with a label.
1) If there any problem like inefficiency run?
2) Any alternate ways to do this like different flag schemes?
3) Any method to have with more than one event for same button to achieve same idea?

Thanks.

Answer 1

1) If there any problem like inefficiency run?

Button clicks run at human time. You can burn half a billion cpu instructions without inconveniencing the user.

2) Any alternate ways to do this like different flag schemes?

Using the Text property of the button is fragile, your code will break when somebody decides to change the button text or when you localize your app to another language. A simple private bool field in your class is much better.

3) Any method to have with more than one event for same button to achieve same idea?

No. You could of course use two buttons, placed on top of each other and one of them always hidden. Makes localization much simpler and you’ll get that bool field for free.