Question

I’ve been benchmarking the performance of a framework I’m writing in Perl and I’m getting a 50% decrease in requests per second over our existing codebase (some hit is understandable, because we’re going from procedural spaghetti code to an OOP MVC framework).

The application is running under mod_perl, and I’ve added Moose and all my framework code into the startup.pl script, which itself doubled my requests per second amount. I’m looking to further enhance this number to get it as close as possible to the existing amount. The argument is there that this is premature optimisation, but there are a couple of glaring inefficiencies that I’d like to fix and see how it effects performance.

Like most frameworks, I have a configuration file and a dispatcher. The config part is handled by Config::General, so a bit of IO and parsing is involved to get my config file loaded into the app. The biggest problem I see here is that I’m doing this for EVERY REQUEST that comes in!

Running Devel::Dprof on my app points to Config::General::BEGIN and a bunch of related IO modules as one of the major slow points that isn’t Moose. So what I’d like to do, and what makes a lot more sense in hindsight is take advantage of mod_perl’s persistence and the startup.pl compilation stuff to only do the work to load in the config file once – when the server starts.

The problem is that I’m not too familiar with how this would work.

Currently each project has a PerlHandler bootstrapping class which is pretty lean and looks like this:

use MyApp;  MyApp->new(config_file => '/path/to/site.config')->run(); 

MyApp.pm inherits from the framework Project module, which has this code:

my $config = Config::General->new(                 -ConfigFile => $self->config_file,                 -InterPolateVars => 1,              );      $self->config({$config->getall}); 

To only do this at compile time, both my bootstrap and Project base modules will have to change (I think), but I’m pretty unsure as to what changes to make and still keep the code nice and lean. Can anyone point me in the right direction here?

UPDATE

I tried the BEGIN BLOCK in each project module approach as described by ysth in his answer. So I now have:

package MyApp::bootstrap; use MyApp;  my $config; BEGIN {     $config = {Config::General->new(...)->getall};         }  sub handler { ..etc.     MyApp->new(config => $config)->run(); 

This quick change alone gave me a 50% increase in requests per second, confirming my thoughts that the config file was a major bottleneck worth fixing. The benchmark figure on our crotchety old dev machine is 60rps, and my framework has went from 30rps to 45rps with this change alone. For those who say Moose is slow and has a compile time hit.. I got the same (50%) increase when compiling all my Moose code at start-up as I did from pre-compiling my config file.

The only problem I have now is that this violates the DRY principal since the same Config::General->new code is in every BEGIN block with only the path to the config file differing. I have a few different strategies to limit this, but I just wanted to post the results of this change.

Answer 1

Assuming your applications don’t change the config at all, move it into a begin block:

# this code goes at file scope my $config; BEGIN {     $config = { Config::General->new( ... )->getall } }  # when creating a new instance $self->config( $config ); 

And make sure all your modules are compiled in startup.pl.

You could get fancier, and have a singleton class provide the config hash, but you don’t need to.