Question

I’ve been looking around, and so far haven’t managed to find a good way to do this. It’s a common problem, I’m sure.

Suppose I have the following:

class SomeClass : IComparable
{ 
    private int myVal; 
    public int MyVal
    { 
        get { return myVal; } 
        set { myVal = value; }
    }

    public int CompareTo(object other) { /* implementation here */ }
}

class SortedCollection<T>
{
    private T[] data;
    public T Top { get { return data[0]; } }

    /* rest of implementation here */
}

The idea being, I’m going to implement a binary heap, and rather than only support Insert() and DeleteMin() operations, I want to support “peeking” at the highest (or lowest, as the case may be) priority value on the stack. Never did like Heisenberg, and that whole “you can’t look at things without changing them” Uncertainty Principle. Rubbish!

The problem, clearly, is that the above provides no means to prevent calling code from modifying MyVal (assuming SortedCollection) via the Top property, which operation has the distinct possibility of putting my heap in the wrong order. Is there any way to prevent modifications from being applied to the internal elements of the heap via the Top property? Or do I just use the code with a warning: “Only stable if you don’t modify any instances between the time they’re inserted and dequeue’d. YMMV.”

Answer 1

To answer your question: No, there’s no way to implement the kind of behavior you want – as long as T is of reference type (and possibly even with some value-types)

You can’t really do much about it. As long as you provide a getter, calling code can modify the internal contents of your data depending on the accessibility of said data (i.e. on properties, fields, and methods).

class SomeClass : IComparable
{ 
    private int myVal; 
    public int MyVal
    { 
        get { return myVal; } 
        set { myVal = value; }
    }

    public int CompareTo(object other) { /* implementation here */ }
}


class SortedCollection<T>
{
    private T[] data;
    public T Top { get { return data[0]; } }

    /* rest of implementation here */
}

//..
// calling code
SortedCollection<SomeClass> col;
col.Top.MyVal = 500;  // you can't really prevent this

NOTE What I mean is you can’t really prevent it in the case of classes that you don’t control. In the example, like others have stated you can make MyVal’s set private or omit it; but since SortedColleciton is a generic class, you can’t do anything about other people’s structures..