Question

I’ve been spending like a whole day just to figure out what is wrong with my coding. Can someone tell me what should i alter just to make my coding working. Thanksssss 🙂

SqlConnection conn = new SqlConnection(ConfigurationManager.ConnectionStrings["Connection"].ConnectionString);
        SqlCommand cmd = new SqlCommand("Insert into ExpTab (username,month,ex1,p1,ex2,p2,ex3,p3,ex4,p4,ex5,p5,ex6,p6,ex7,p7,ex8,p8,,p3,p4,p5,p6,p7,p8) Values (@name,@month1,@ex1s,@p1s,@ex2s,@p2s,@ex3s,@p3s,@ex4s,@p4s,@ex5s,@p5s,@ex6s,@p6s,@ex7s,@p7s,@ex8s,@p8s)", conn);

    cmd.CommandType = CommandType.Text;
    cmd.Parameters.AddWithValue("@name", Membership.GetUser().UserName);
    cmd.Parameters.AddWithValue("@month1", Label1.Text);
    cmd.Parameters.AddWithValue("@ex1s", Label18.Text);
    cmd.Parameters.AddWithValue("@p1s", Label20.Text);
    cmd.Parameters.AddWithValue("@ex2s", Label2.Text);
    cmd.Parameters.AddWithValue("@p2s", Label21.Text);
    cmd.Parameters.AddWithValue("@ex3s", Label3.Text);
    cmd.Parameters.AddWithValue("@p3s", Label22.Text);
    cmd.Parameters.AddWithValue("@ex4s", Label4.Text);
    cmd.Parameters.AddWithValue("@p4s", Label23.Text);
    cmd.Parameters.AddWithValue("@ex5s", Label5.Text);
    cmd.Parameters.AddWithValue("@p5s", Label24.Text);
    cmd.Parameters.AddWithValue("@ex6s", Label6.Text);
    cmd.Parameters.AddWithValue("@p6s", Label25.Text);
    cmd.Parameters.AddWithValue("@ex7s", Label7.Text);
    cmd.Parameters.AddWithValue("@p7s", Label26.Text);
    cmd.Parameters.AddWithValue("@ex8s", Label8.Text);     
    cmd.Parameters.AddWithValue("@p8s", Label27.Text);

    conn.Open();
    cmd.ExecuteNonQuery();

I really need help 🙁

Answer 1

What is this little snippet:

... p7,ex8,p8,,p3,p4,p5 ...
             ^^

meant to be?

That’s a rhetorical question by the way, since at least one commenter didn’t understand that 🙂 That’s where your trouble lies.

In fact, since you have 24 column names (excluding the empty one between the commas) and only 18 values to be inserted (and also based on the column/value names), it’s a near-certainty that the entire section from that second comma onwards is superfluous. Try removing the entire ,,p3,p4,p5,p6,p7,p8 and using this:

insert into ExpTab ( 
    username, month, ex1, p1, ex2, p2, ex3, p3,
    ex4, p4, ex5, p5, ex6, p6, ex7, p7, ex8, p8
) values (
    @name, @month1, @ex1s, @p1s, @ex2s, @p2s, @ex3s, @p3s,
    @ex4s, @p4s, @ex5s, @p5s, @ex6s, @p6s, @ex7s, @p7s, @ex8s, @p8s)

That should fix your problem.