Home/ Questions/Q 6343111
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-24T20:22:20+00:00

I’ve been teaching myself JavaScript and i’m still fairly new, i’ve tried to make

  • 0

I’ve been teaching myself JavaScript and i’m still fairly new, i’ve tried to make a clock feature to add to my site, however, I can’t see to get it to display, this is my full code:

<html>
<head>
<script type="text/javascript">
    function tick() {
        var hours, minutes, seconds, ap;
        var intHours, intMinutes, intSeconds;
        var today;

        today = new Date();

        intHours = today.getHours();
        intMinutes = today.getMinutes();
        intSeconds = today.getSeconds();

        if (intHours == 0) {
            hours = "12:";
            ap = "Midnight";
        } else if (intHours < 12) {
            hours = intHours + ":";
            ap = "a.m";
        } else if (intHours == 12) {
            hours = "12:";
            ap = "noon";
        } else {
            intHours = intHours - 12
            hours = intHours + ":";
            ap = "p.m.";
        }
        if (intMinutes < 10) {
            minutes = "0" + intMinutes + ":";
        } else {
            minutes = intMinutes + ":";
        }
        if (intSeconds < 10) {
            seconds = "0" + intSeconds + " ";
        } else {
            seconds = intSeconds + " ";
        }
        timeString = hours + minutes + seconds + ap;

        Clock.innerHTML = timeString;

        window.setTimeout("tick();", 100);
    }

    //--></script>
</head>
<body>
<div id="Clock" align="center" style="font-family: Verdana; font-size: 10px; color:#000000"></div>
 </body>
 </html>

As I said, I run it and as far as I can see, it should run fine, as I said i’m a bit new, so maybe someone could help me out.

Thanks again people.

EDIT: Before anyone says, I am fully aware that there are premade working examples of this kind of thing, such as jQuery clocks etc, but I wanted to make one myself from scratch.

Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    It is not starting, mainly because you need to call the function at least once initially:

    tick();

    Where ever you are learning HTML and JavaScript from, stop learning from there immediately; the code habits and methods you are learning are very, very poor and outdated.

    Problems include:

    • not having a DOCTYPE: <!DOCTYPE html>
    • accessing div#Clock as a global variable Clock, which is deprecated, and should be document.getElementById('Clock');
    • using a string to setTimeout, when it should really be setTimeout(tick, 100);
    • using the deprecated align attribute, when you should use text-align: center; in CSS
    • using the ‘old-browser’ JavaScript comment-out trick
    • using inline CSS via the style attribute, which constitutes poor separation of presentation and content
    • 0