Question

I’ve created a custom validator for my project, it simply checks the select ones value and ‘validates’ the value is not ‘0’. We have a standard (I’m sure not uncommon) of manually setting the first value of our selectOneMenu compents to:

<f:selectItem itemValue="0"
              itemLabel="-- Select One --"/>

Which works fine, but then makes the component always pass the required check. So this validator simply treats this value as if there was no selection made.

SelectOneMenu example:

<h:selectOneMenu id="eligibility"
             value="#{reg.eligibility}"
             required="#{reg.fieldsRequired}">
<f:selectItem itemValue="0"
              itemLabel="-- Select One --"/>
<f:selectItems value="#{reg.eligibilityList}" />
<f:validator validatorId="selectOneValidator"
             disabled="#{!reg.fieldsRequired}"/>

Custom Validator:

@FacesValidator("selectOneValidator")

public class SelectOneValidator implements Validator {

@Override
public void validate(FacesContext context, UIComponent uiComponent, Object o) throws ValidatorException {
    String val = null;
    if (uiComponent instanceof HtmlSelectOneMenu) {
        HtmlSelectOneMenu oneMenu = (HtmlSelectOneMenu) uiComponent;


        if (oneMenu.isRequired() && !oneMenu.isDisabled()) {
            if (o instanceof String) {
                val = (String) o;
            } else if (o instanceof Number) {
                val = String.valueOf(o);
            }

            if ("0".equals(val)) {
                FacesMessage msg = new FacesMessage();
                msg.setSummary("Please select a value from the list.");
                msg.setSeverity(FacesMessage.SEVERITY_ERROR);
                throw new ValidatorException(msg);
            }
        }
    }
}

}

This has worked just fine thus far, however, the current use-case I’m running into trouble.
My page has multiple SelectOneMenus one of which toggles the required and disabled attributes via an ajax call for the page. I’m not having any issues with the required="#{reg.fieldsRequired}", however; the disabled="#{!reg.fieldsRequired}" attribute on my custom validator does not seem to make a difference. I’m just thinking out loud, but when the page first loads the #{reg.fieldsRequired} expression is false. If I then change the SelectOneMenu to set this boolean value to true, then press the submit button, the disabled attribute doesn’t seem to have been set. I wondered if this is simply a ajax issue and that all of components simply needed to be re-renderd so I added the @form in my ajax call: <a4j:ajax render="@form" listener="#{reg.saveActionChanged}"/> in hopes that would fix the problem, but no difference in the behavior.

Environment:
JSF 2.0.3
Tomcat 6.0.14
ajax call being made with RichFaces 4.0

Any help is most appreciated!

Answer 1

Sorry, I can’t reproduce your problem with JSF 2.1.3. The <f:validator disabled> works as expected.

However, as a completely different alternative, you can in this particular case just make use of the standard required validator. You only need to set the item value to #{null} instead of 0.

<f:selectItem itemValue="#{null}" itemLabel="-- Select One --"/>

This way you don’t need the custom validator. The message can be set as requiredMessage attribute of the input component.

<h:selectOneMenu requiredMessage="Please select a value from the list.">