Question

I’ve got a form that has several mandatory fields, all of which work except the drop-down.

I’m using this code to check the fields:

function formCheck(formobj){
    // Enter name of mandatory fields
    var fieldRequired = Array("name", "country", "email", "tel");
    // Enter field description to appear in the dialog box
    var fieldDescription = Array("Name", "Country", "Email", "Telephone");
    // dialog message
    var alertMsg = "Please complete the following fields:\n";

    var l_Msg = alertMsg.length;

    for (var i = 0; i < fieldRequired.length; i++){
        var obj = formobj.elements[fieldRequired[i]];
        if (obj){
            switch(obj.type){
            case "select-one":
                if (obj.selectedIndex == -1 || obj.options[obj.selectedIndex].text == ""){
                    alertMsg += " - " + fieldDescription[i] + "\n";
                }
                break;
            case "select-multiple":
                if (obj.selectedIndex == -1){
                    alertMsg += " - " + fieldDescription[i] + "\n";
                }
                break;
            case "text":
            case "textarea":
                if (obj.value == "" || obj.value == null){
                    alertMsg += " - " + fieldDescription[i] + "\n";
                }
                break;
            default:
            }
            if (obj.type == undefined){
                var blnchecked = false;
                for (var j = 0; j < obj.length; j++){
                    if (obj[j].checked){
                        blnchecked = true;
                    }
                }
                if (!blnchecked){
                    alertMsg += " - " + fieldDescription[i] + "\n";
                }
            }
        }
    }

    if (alertMsg.length == l_Msg){
        return true;
    }else{
        alert(alertMsg);
        return false;
    }
}

This is the code I’m using for the drop down:

<select name="country" id="country">
                        <option value="" disabled="disabled">Please select your country</option>
                        <option value="United Kingdom">United Kingdom</option>
                        <option value="United States">United States</option>
...

What am I missing to make the user select a country rather than them leaving it on “Please select your country” and it returning nothing?

Answer 1

For your example this code will always result to true:

obj.selectedIndex == -1 || obj.options[obj.selectedIndex].text == ""

Both will evaluate to true. Try changing it to:

obj.selectedIndex == 0