Question

I’ve got a tableview loaded from an array and for some reason it’s re-using the cell but loading the same information lower down the table, a second time.

http://screencast.com/t/Ig8bcqSpLzp

The video above should give you an idea of what I mean.

This is my code to load the cell:

  - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {

    static NSString *CellIdentifier = @"Cell";

    UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];
    if (cell == nil) {

        cell = [[[UITableViewCell alloc] initWithFrame:CGRectZero reuseIdentifier:CellIdentifier] autorelease];
    }
        accessicon *current =[arryAccess objectAtIndex:indexPath.row] ;
        cell.textLabel.text = current.text;
        cell.imageView.image = [UIImage imageNamed: current.iconPath];
        cell.selectionStyle = UITableViewCellSelectionStyleNone;
        mySwitch *switchView = [[mySwitch alloc] initWithFrame:CGRectZero];
        cell.accessoryView = switchView;
        switchView.myValue = current.iconValue;

        if(totalIconValue & current.iconValue) {
            [switchView setOn: YES animated:NO];
        } else {
            [switchView setOn: NO animated:NO];

        }

        [switchView addTarget:self action:@selector(switchChanged:) forControlEvents:UIControlEventValueChanged];
        [switchView release];


        return cell;


}

Any help will be appreciated

EDIT: I’ve updated my code above, however on the actual device it’s still selecting items it shouldn’t be – no longer reusing the names but if i scroll up and down it selects them on it’s own?

see the video here: http://screencast.com/t/a9N1qbws

Tom

Answer 1

This code:

UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];
cell = [[[UITableViewCell alloc] initWithFrame:CGRectZero reuseIdentifier:CellIdentifier] autorelease];
if (cell == nil) {
    ...

is fundamentally wrong. It should read:

UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];
if (cell == nil) {
    cell = [[[UITableViewCell alloc] initWithFrame:CGRectZero reuseIdentifier:CellIdentifier] autorelease];
    ...

And then, anything that is row-specific should be outside that if statement.

The pattern for this, generally, should be:

• dequeue a reusable cell
• if you didn’t get one:
  • allocate a new cell
  • perform generic cell setup, i.e. setup that applies to all cells
• setup the cell for the specific row, and return it.

Hope this helps.