Question

I’ve got the following code snippet that I’m thinking of refactoring to a more abstract application exception handler but I want to make sure I’ve got it as tidy as possible first

Any suggestions on how to improve this code or make it more resuable

int id = -1;
final StringBuilder errorMessage = new StringBuilder("Bad Input Value: ");
try {
        id = Integer.parseInt(edtId.getText().toString());
} catch (final NumberFormatException e) {
        errorMessage.append("Failed to parse id " + e.getMessage());
}

if (id < 0) {
    errorToast(errorMessage.toString());
} else {
    //go ahead an retreive values from database knowing the id has been parsed
    //correctly to a positive int.
}

Answer 1

Why pre-assign id to a magic number?

try {
    int id=Integer.parseInt(edtId.getText().toString());
    //go on as normal
} catch (NumberFormatException e) {
    //handle error
}