Question

I’ve inherited some code… and am trying to convert it to use MVC 3, with Razor, the VBHTML is as follows:

    For Each Message As MessageDetailsModel In Model.Messages
        @<div id='@Message.HeaderId' class='@Message.HeaderCss' onclick=@(String.Format("shMsgTree('{0}','{1}',{2},'{3}');", Message.HeaderCss, Message.HeaderId, Message.MessageId, Message.UserId))>
            ... more stuff...
        </div>
    Next

Stepping through the code, the String.format resolves to this:

shMsgTree('sh_msg_GridItem sh_msg_MessageRead ','divHeader0',40,'{85A433F0-4054-42E7-B778-3EF005E411D3}');

which is what I want on the page, but for some reason, it gets output on the page as this:

shMsgTree('sh_msg_GridAltItem" sh_msg_MessageRead="

The properties on the model are all strings.

Am at a bit of a loss as to how to get it to render. Originally the entire onclick javascript was being returned in the Model, but that didn’t render any better either.

Any suggestions would really be welcome. Thanks!

Answer 1

Given our conversation in the comments and the fact that the original Razor is quite hard to read, I think I’d recommend either:

• writing a Razor Helper for this small block of code http://weblogs.asp.net/scottgu/archive/2011/05/12/asp-net-mvc-3-and-the-helper-syntax-within-razor.aspx
• or writing a normal Extension Method to output the code – http://weblogs.asp.net/jgalloway/archive/2011/03/23/comparing-mvc-3-helpers-using-extension-methods-and-declarative-razor-helper.aspx (this is what I would choose!)

Without stepping through it in code, it’s too hard to read the syntax as currently written – so break it out into a separate compact, testable, readable component.

Hope that helps

Stuart